Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for graph_runtime Init lookup_linked_param_func #7676

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

apivovarov
Copy link
Contributor

@apivovarov apivovarov commented Mar 17, 2021

In previous TVM version GraphRuntime Init method had 3 parameters.

  • graph_json The execution graph
  • module The module containing the compiled functions
  • ctxs The context of the host and devices

Now Init method has one additional parameter:

  • lookup_linked_param_func If given, a PackedFunc invoked to lookup

In most of the cases this parameter is set to nullptr.

To keep GraphRuntime API backward compatibility we can make new parameter lookup_linked_param_func optional by setting its default value to nullptr.

Copy link
Contributor

@d-smirnov d-smirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@anijain2305 anijain2305 merged commit 431a7d6 into apache:main Mar 18, 2021
@anijain2305
Copy link
Contributor

Thanks @apivovarov @d-smirnov @zhiics

AndrewZhaoLuo pushed a commit to AndrewZhaoLuo/tvm that referenced this pull request Mar 22, 2021
* main:
  [AutoScheduler] Add function name in message (apache#7703)
  [Vulkan] Workaround for zero size allocation (apache#7691)
  Change behavior of onnx importer to throw when user provides an input no in the graph. (apache#7699)
  Free TensorRT engine and context (apache#7702)
  [TFLite] Cast operator adapted for MLIR-based convertor (apache#7639)
  [CPP_RPC] allow user supplied work dir (apache#7670)
  Default value for graph_runtime Init lookup_linked_param_func (apache#7676)
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants